-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-5218): use primary preferred in socks test #3654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should establish why the tests are still failing before merging this change
Just note Socks5 tests are no longer failing, it's CSFLE tests using the setup method (https://parsley.mongodb.com/evergreen/mongo_node_driver_rhel80_large_hydrogen_test_socks5_patch_134d32ffe0b37977d71508a2f4484ba60139c9fc_6447b201d6d80a48233dd285_23_04_25_10_57_06/0/task?bookmarks=0,2618). Adding commit to attempt to debug the new failures. |
Current failures same as main branch with missing Range options: https://spruce.mongodb.com/task/mongo_node_driver_next_rhel8_custom_dependency_tests_run_custom_csfle_tests_5.0_master_ce8e69b6db0eb4c0b9271ce43e334d70b967d227_23_05_01_17_15_46/logs?execution=0&sortBy=STATUS&sortDir=ASC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the failures are different than the one we're fixing here which is the flaky primary scenario. There's the index test change that will fix when we publish a new version of FLE and what looks like flaky KMS request which we have a separate ticket for.
@dariakp, re: my comment above, is that satisfactory for merging? |
Description
Backports Sock5 test fix.
What is changing?
Uses primaryPreferred read preference in tests.
#3506
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5218
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript