Skip to content

test(NODE-5218): use primary preferred in socks test #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2023
Merged

Conversation

durran
Copy link
Member

@durran durran commented Apr 25, 2023

Description

Backports Sock5 test fix.

What is changing?

Uses primaryPreferred read preference in tests.

#3506

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5218

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

addaleax
addaleax previously approved these changes Apr 25, 2023
@dariakp dariakp added the wip label Apr 25, 2023
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should establish why the tests are still failing before merging this change

@durran
Copy link
Member Author

durran commented Apr 26, 2023

Just note Socks5 tests are no longer failing, it's CSFLE tests using the setup method (https://parsley.mongodb.com/evergreen/mongo_node_driver_rhel80_large_hydrogen_test_socks5_patch_134d32ffe0b37977d71508a2f4484ba60139c9fc_6447b201d6d80a48233dd285_23_04_25_10_57_06/0/task?bookmarks=0,2618). Adding commit to attempt to debug the new failures.

@durran durran removed the wip label May 2, 2023
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the failures are different than the one we're fixing here which is the flaky primary scenario. There's the index test change that will fix when we publish a new version of FLE and what looks like flaky KMS request which we have a separate ticket for.

@nbbeeken nbbeeken self-assigned this May 3, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 3, 2023
@nbbeeken
Copy link
Contributor

nbbeeken commented May 3, 2023

We should establish why the tests are still failing before merging this change

@dariakp, re: my comment above, is that satisfactory for merging?

@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 3, 2023
@nbbeeken nbbeeken changed the title test(NODE-5218): use primary preferred in socks test (#3506) test(NODE-5218): use primary preferred in socks test May 3, 2023
@nbbeeken nbbeeken merged commit bf92d10 into 4.x May 3, 2023
@nbbeeken nbbeeken deleted the NODE-5218 branch May 3, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants