Skip to content

test(NODE-4580): use primary preferred in socks test #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2022
Merged

test(NODE-4580): use primary preferred in socks test #3506

merged 1 commit into from
Dec 29, 2022

Conversation

durran
Copy link
Member

@durran durran commented Dec 28, 2022 •
edited
Loading

Description

Fix Socks5 flaky tests

What is changing?

  • Updates the single connection URI to use read preference primary preferred to avoid the "not primary and secondaryOk=false" errors.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4580

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review December 28, 2022 16:33
@durran durran merged commit b4e63fb into main Dec 29, 2022
@durran durran deleted the NODE-4580 branch December 29, 2022 05:33
durran added a commit that referenced this pull request Apr 25, 2023
@durran
test(NODE-4580): use primary preferred in socks test (#3506)
8d2e743
@nbbeeken nbbeeken mentioned this pull request May 3, 2023
Merged
5 tasks
@nbbeeken
Copy link
Contributor

nbbeeken commented May 3, 2023

backported in #3654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @nbbeeken