DRIVERS-3139: Revise assertion for unacknowledged client bulkWrite result #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult This makes the assertion consistent with collection bulkWrites by allowing for an entirely optional result and conditionally checking acknowledged=false.
jmikola
commented
Mar 19, 2025
| deletedCount: { $$unsetOrMatches: 0 } | ||
| insertResults: { $$unsetOrMatches: {} } | ||
| updateResults: { $$unsetOrMatches: {} } | ||
| deleteResults: { $$unsetOrMatches: {} } |
There was a problem hiding this comment.
I decided to leave these additional assertions in place, but I'll note they were never included in the legacy bulkWrite tests (example).
It seemed more important to just allow for an entirely optional result and conditionally check acknowledged.
alcaeus
approved these changes
Mar 20, 2025
isabelatkinson
approved these changes
Mar 20, 2025
kevinAlbs
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Test passes in C driver: https://spruce.mongodb.com/version/67dc28318e83830007a19d14
C driver tests pass before this change. I expect this is due to the C driver test runner representing an unacknowledged result as an empty BSON document. The match of {} against { "insertedCount": { "$$unsetOrMatches": 0 } , ... } passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-3139
This makes the assertion consistent with collection bulkWrites by allowing for an entirely optional result and conditionally checking acknowledged=false.
Please complete the following before merging: