Skip to content

DRIVERS-3139: Revise assertion for unacknowledged client bulkWrite result #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

DRIVERS-3139: Revise assertion for unacknowledged client bulkWrite result #1772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 28 additions & 23 deletions source/command-logging-and-monitoring/tests/monitoring/unacknowledged-client-bulkWrite.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 10 additions & 16 deletions source/command-logging-and-monitoring/tests/monitoring/unacknowledged-client-bulkWrite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,22 +52,16 @@ tests:
update: { $set: { x: 333 } }
ordered: false
expectResult:
insertedCount:
$$unsetOrMatches: 0
upsertedCount:
$$unsetOrMatches: 0
matchedCount:
$$unsetOrMatches: 0
modifiedCount:
$$unsetOrMatches: 0
deletedCount:
$$unsetOrMatches: 0
insertResults:
$$unsetOrMatches: {}
updateResults:
$$unsetOrMatches: {}
deleteResults:
$$unsetOrMatches: {}
$$unsetOrMatches:
acknowledged: { $$unsetOrMatches: false }
insertedCount: { $$unsetOrMatches: 0 }
upsertedCount: { $$unsetOrMatches: 0 }
matchedCount: { $$unsetOrMatches: 0 }
modifiedCount: { $$unsetOrMatches: 0 }
deletedCount: { $$unsetOrMatches: 0 }
insertResults: { $$unsetOrMatches: {} }
updateResults: { $$unsetOrMatches: {} }
deleteResults: { $$unsetOrMatches: {} }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to leave these additional assertions in place, but I'll note they were never included in the legacy bulkWrite tests (example).

It seemed more important to just allow for an entirely optional result and conditionally check acknowledged.

# Force completion of the w:0 write by executing a find on the same connection
- object: *collection
name: find
Expand Down
Loading