Skip to content

chore: Temporary fix on tenant cluster test passing zone name explicitly #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2025
Merged

chore: Temporary fix on tenant cluster test passing zone name explicitly #3078

merged 2 commits into from
Feb 17, 2025

Conversation

AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Feb 17, 2025 •
edited
Loading

Description

Link to any related issue(s): related to CLOUDP-301101

Ran test locally

^TestAccAdvancedCluster_basicTenant$ github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster

ok  	github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster	521.168s

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the bug label Feb 17, 2025
@AgustinBettati AgustinBettati marked this pull request as ready for review February 17, 2025 17:21
@AgustinBettati AgustinBettati requested a review from a team as a code owner February 17, 2025 17:21
marcosuma
marcosuma reviewed Feb 17, 2025
View reviewed changes
internal/service/advancedcluster/resource_advanced_cluster_test.go
Check: checkTenant(true, projectID, clusterName),
},
{
Config: configTenant(t, true, projectID, clusterNameUpdated, ""),
Config: configTenant(t, true, projectID, clusterNameUpdated, "Zone 1"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a comment here too

@AgustinBettati AgustinBettati merged commit 9fa210c into master Feb 17, 2025
39 checks passed
@AgustinBettati AgustinBettati deleted the temp-fix-tenant-test branch February 17, 2025 17:59
lantoli added a commit that referenced this pull request Feb 17, 2025
@lantoli
Merge branch 'master' into CLOUDP-274025-dev-docs-examples
f5841fa 
* master:
  chore: Temporary fix on tenant cluster test passing zone name explicitly (#3078)
  exempt dependencies PR labels from being stale (#3073)
  use helper methods (#3072)
  chore: Bump golangci/golangci-lint-action from 6.3.0 to 6.5.0 (#3074)
  chore: Bump goreleaser/goreleaser-action from 6.1.0 to 6.2.1 (#3056)
@lantoli
Copy link
Member

lantoli commented Feb 17, 2025

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosuma marcosuma marcosuma approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AgustinBettati @lantoli @marcosuma