Skip to content

chore: Temporary fix on tenant cluster test passing zone name explicitly #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025
Merged

chore: Temporary fix on tenant cluster test passing zone name explicitly #3078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c256685
chore: Temporary fix on tenant cluster test passing zone name explicitly
AgustinBettati Feb 17, 2025
e67cff8
add additional comment in second step
AgustinBettati Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/service/advancedcluster/resource_advanced_cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,13 @@ func TestAccAdvancedCluster_basicTenant(t *testing.T) {
CheckDestroy: acc.CheckDestroyCluster,
Steps: []resource.TestStep{
{
Config: configTenant(t, true, projectID, clusterName, ""),
// zone name is hardcoded directly as a temporary fix, depends on CLOUDP-300819 or CLOUDP-301101
Config: configTenant(t, true, projectID, clusterName, "Zone 1"),
Check: checkTenant(true, projectID, clusterName),
},
{
Config: configTenant(t, true, projectID, clusterNameUpdated, ""),
// zone name is hardcoded directly as a temporary fix, depends on CLOUDP-300819 or CLOUDP-301101
Config: configTenant(t, true, projectID, clusterNameUpdated, "Zone 1"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a comment here too

Check: checkTenant(true, projectID, clusterNameUpdated),
},
acc.TestStepImportCluster(resourceName),
Expand Down