doc: Updates examples with newly added attributes to mongodbatlas_search_deployment and mongodbatlas_encryption_at_rest
#3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tf-validate check will fail until #3152 is merged |
AgustinBettati
approved these changes
Mar 17, 2025
| @@ -41,6 +41,8 @@ resource "mongodbatlas_encryption_at_rest" "test" { | |||
| region = var.atlas_region | |||
| role_id = mongodbatlas_cloud_provider_access_authorization.auth_role.role_id | |||
| } | |||
|
|
|||
| enabled_for_search_nodes = true | |||
There was a problem hiding this comment.
Unrelated to this PR, see you mentioned the attribute is optional + computed and wanted to confirm if this is due to the API (always returned even when not defined).
There was a problem hiding this comment.
Exactly, it's always returned by the API even when not defined
lantoli
reviewed
Mar 17, 2025
lantoli
approved these changes
Mar 17, 2025
|
APIx bot: a message has been sent to Docs Slack channel |
oarbusi
added a commit
that referenced
this pull request
Apr 4, 2025
* feat: Supports configuring BYOK encryption on search nodes (#3142) * use SDK preview in encryption_at_rest * changelog * Revert "use SDK preview in encryption_at_rest" This reverts commit 609c9dc. * trigger change in EAR * Revert "trigger change in EAR" This reverts commit 15794dd. * Reapply "use SDK preview in encryption_at_rest" This reverts commit 1c2db30. * TEMPORARY: send enabled_for_search_nodes = true * finish resource implementation and tests * data source implementation and test * doc update * default and refactor test * remove old migration test * default value in resource * unit test --------- Co-authored-by: Oriol Arbusi <[email protected]> * feat: Adds `encryption_at_rest_provider` to `mongodbatlas_search_deployment` resource and data source (#3152) * use preview * add encryption_at_rest_provider computed attribute * remove check * dosc * rename files * move adv_cluster config out of resources * fix config * project id * add TODO to version * doc: Updates examples with newly added attributes to `mongodbatlas_search_deployment` and `mongodbatlas_encryption_at_rest` (#3174) * add new attribute to the example * examples updates * nit: end with new line * fix tf validate * todos * PR suggestions + test failure --------- Co-authored-by: Leo Antoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates examples with newly added attributes to
mongodbatlas_search_deploymentandmongodbatlas_encryption_at_rest. The attributes areenabled_for_search_nodes(optional & computed) andencryption_at_rest_provider(computed). This is a follow up to #3142 and #3152Link to any related issue(s): CLOUDP-296693
Type of change:
Required Checklist:
Further comments