-
Notifications
You must be signed in to change notification settings - Fork 189
feat: Support configuring BYOK encryption on search nodes #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* use SDK preview in encryption_at_rest * changelog * Revert "use SDK preview in encryption_at_rest" This reverts commit 609c9dc. * trigger change in EAR * Revert "trigger change in EAR" This reverts commit 15794dd. * Reapply "use SDK preview in encryption_at_rest" This reverts commit 1c2db30. * TEMPORARY: send enabled_for_search_nodes = true * finish resource implementation and tests * data source implementation and test * doc update * default and refactor test * remove old migration test * default value in resource * unit test --------- Co-authored-by: Oriol Arbusi <[email protected]>
…oyment` resource and data source (#3152) * use preview * add encryption_at_rest_provider computed attribute * remove check * dosc * rename files * move adv_cluster config out of resources * fix config * project id * add TODO to version
…arch_deployment` and `mongodbatlas_encryption_at_rest` (#3174) * add new attribute to the example * examples updates * nit: end with new line * fix tf validate
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
APIx bot: a message has been sent to Docs Slack channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some comments and questions
@@ -135,40 +136,3 @@ func TestMigEncryptionAtRest_basicGCP(t *testing.T) { | |||
}, | |||
}) | |||
} | |||
|
|||
func TestMigEncryptionAtRest_basicAWS_from_v1_11_0(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] why is this no longer required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed here, let me know if there is any other concern
only failing test in |
* master: chore: Updates org_clean_test.go to delete stream instances & private endpoint services (#3252) chore: Updates organization.md `skip_default_alerts_settings` note format (#3246) doc: Update guidelines for external contributors to squash commits (#3243) chore: Updates CHANGELOG.md for #3199
Description
Support configuring BYOK encryption on search nodes:
enabled_for_search_nodes
attribute tomongodbatlas_encryption_at_rest
resource and data sourceencryption_at_rest_provider
computed attribute tomongodbatlas_search_deployment
resource and data sourceLink to any related issue(s): CLOUDP-296693
Type of change:
Required Checklist:
Further comments