Skip to content

AnimationClipCreator: default to empty string for clip name #30666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

AnimationClipCreator: default to empty string for clip name #30666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions examples/jsm/animation/AnimationClipCreator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class AnimationClipCreator {

const track = new NumberKeyframeTrack( trackName, times, values );

return new AnimationClip( null, period, [ track ] );
return new AnimationClip( '', period, [ track ] );

}

Expand All @@ -50,7 +50,7 @@ class AnimationClipCreator {

const track = new NumberKeyframeTrack( trackName, times, values );

return new AnimationClip( null, period, [ track ] );
return new AnimationClip( '', period, [ track ] );

}

Expand All @@ -59,7 +59,7 @@ class AnimationClipCreator {
* in the given period.
*
* @param {number} duration - The duration of the animation.
* @param {number} shakeScale - The scale of the shake.
* @param {Vector3} shakeScale - The scale of the shake.
* @return {AnimationClip} The created animation clip.
*/
static CreateShakeAnimation( duration, shakeScale ) {
Expand All @@ -80,7 +80,7 @@ class AnimationClipCreator {

const track = new VectorKeyframeTrack( trackName, times, values );

return new AnimationClip( null, duration, [ track ] );
return new AnimationClip( '', duration, [ track ] );

}

Expand Down Expand Up @@ -110,7 +110,7 @@ class AnimationClipCreator {

const track = new VectorKeyframeTrack( trackName, times, values );

return new AnimationClip( null, duration, [ track ] );
return new AnimationClip( '', duration, [ track ] );

}

Expand All @@ -128,7 +128,7 @@ class AnimationClipCreator {

const track = new BooleanKeyframeTrack( trackName, times, values );

return new AnimationClip( null, duration, [ track ] );
return new AnimationClip( '', duration, [ track ] );

}

Expand Down Expand Up @@ -158,7 +158,7 @@ class AnimationClipCreator {

const track = new ColorKeyframeTrack( trackName, times, values );

return new AnimationClip( null, duration, [ track ] );
return new AnimationClip( '', duration, [ track ] );

}

Expand Down
Loading