Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUTImageLoader: Harmonize ctor. #30720

Merged
merged 2 commits into from
Mar 11, 2025
Merged

LUTImageLoader: Harmonize ctor. #30720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb1dc6
LUTImageLoader: Harmonize ctor.
Mugen87 Mar 11, 2025
9726f18
Update LUTImageLoader.js
Mugen87 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions examples/jsm/loaders/LUTImageLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,23 @@ export class LUTImageLoader extends Loader {
/**
* Constructs a new LUT loader.
*
* @param {boolean} [flipVertical=false] - Whether to vertically flip the LUT or not.
* @param {LoadingManager} [manager] - The loading manager.
*/
constructor( flipVertical = false ) {
constructor( manager ) {

//The NeutralLUT.png has green at the bottom for Unreal ang green at the top for Unity URP Color Lookup
//post-processing. If you're using lut image strips from a Unity pipeline then pass true to the constructor

super();
super( manager );

/**
* Whether to vertically flip the LUT or not.
*
* Depending on the LUT's origin, the texture has green at the bottom (e.g. for Unreal)
* or green at the top (e.g. for Unity URP Color Lookup). If you're using lut image strips
* from a Unity pipeline, then set this property to `true`.
*
* @type {boolean}
* @default false
*/
this.flip = flipVertical;
this.flip = false;

}

Expand Down
Loading