Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUTImageLoader: Harmonize ctor. #30720

Merged
merged 2 commits into from
Mar 11, 2025
Merged

LUTImageLoader: Harmonize ctor. #30720

merged 2 commits into from
Mar 11, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 11, 2025

Related issue: -

Description

LUTImageLoader is the only loader with an inconsistent ctor signature. The PR ensures the loading manager can be pass to the ctor and removes the flipVertical parameter. Users are supposed to assign a value directly to the property now.

@Mugen87 Mugen87 merged commit a1358b4 into mrdoob:dev Mar 11, 2025
11 checks passed
@Mugen87 Mugen87 added this to the r175 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant