Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Fix .blur() on Framebuffer #30845

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #30722

Description
blur() was broken on TextureNode with Framebuffer value such as ViewportSharedTextureNode. This PR fixes the issue.

This contribution is funded by Renaud Rohlinger @ Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r176 milestone Apr 2, 2025
Copy link

github-actions bot commented Apr 2, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.36
78.34
336.36
78.34
+0 B
+0 B
WebGPU 533.07
148.15
533.1
148.16
+24 B
+7 B
WebGPU Nodes 532.54
148.05
532.56
148.06
+24 B
+8 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.37
112.21
465.37
112.21
+0 B
+0 B
WebGPU 604.68
164.12
604.71
164.13
+24 B
+10 B
WebGPU Nodes 559.67
153.56
559.7
153.56
+24 B
+5 B

@sunag sunag changed the title TextureNode: Fix .blur() on Framebuffer TSL: Fix .blur() on Framebuffer Apr 2, 2025
@sunag sunag merged commit 19d07ee into mrdoob:dev Apr 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants