Refactoring Slice - Add Statement Configuration to Rendering Context #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shares the configuration among all query expressions so that union queries will have the same configuration
This separate the concept of a standalone where clause from a where clause that is a part of another statetment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slice adds the statement configuration to the rendering context. This makes it possible to query statement configuration whenever rendering happens.
This PR also makes configuration available on all statements where it could make a change in rendering (including multi-selects and insert selects which were not included previously).
Further, this PR makes statement configuration consistent across all statements and enforces the rule that configuration on embedded select statements is ignored - only configuration on the outermost statement is in effect.