Optionally Allow Empty List Conditions to Render #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a configuration setting to allow empty list conditions to render. This could cause an SQLException at runtime, but might be useful as a safety measure for unvalidated input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration setting to allow empty list conditions to render. By default, empty list conditions will be dropped from a where clause - which could generate a statement that affects more rows then expected. This change adds a configuration setting that will allow empty list conditions to render. An example of a rendered empty list condition would be
in ()ornot in (). This is invalid SQL and it could cause an SQLException at runtime, but it might be useful as a safety measure for unvalidated input.Preceded by refactoring slices #754 and #763
Resolves #752
Also related to #228, #509, and #562