Skip to content

ReferenceError: window is not defined #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hkennyv opened this issue Jul 22, 2020 · 2 comments
Closed

ReferenceError: window is not defined #318

hkennyv opened this issue Jul 22, 2020 · 2 comments

Comments

@hkennyv
Copy link
Contributor

hkennyv commented Jul 22, 2020

Hey all,

It seems like there is an error when using netlify-identity-widget 1.8.0. This error is not present when reverting netlify-identity-widget back to 1.6.0.

Some steps to reproduce this error:

  • clone the repository here (I was following along with this article)
  • install deps - yarn install
  • try to run dev server - yarn dev

To get rid of this error by reverting back to 1.6.0:

  • delete node_modules - rm -rf node_modules/
  • change version of netlify-identity-widget from ^1.8.0 to 1.6.0 in package.json
  • reinstall deps - yarn install
  • start dev server - yarn dev

The error is posted below:

ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
ReferenceError: window is not defined
    at Object.<anonymous> (/Users/khuynh/me/develop/web/nextapp/node_modules/netlify-identity-widget/build/netlify-identity.js:1:212)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at eval (webpack-internal:///netlify-identity-widget:1:18)
    at Object.netlify-identity-widget (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:416:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./utils/netlifyAuth.js:2:81)
    at Module../utils/netlifyAuth.js (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:382:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
    at eval (webpack-internal:///./pages/index.tsx:5:76)
    at Module../pages/index.tsx (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:347:1)
    at __webpack_require__ (/Users/khuynh/me/develop/web/nextapp/.next/server/static/development/pages/index.js:29:31)
hkennyv added a commit to hkennyv/netlify-identity-widget that referenced this issue Jul 22, 2020
@hkennyv
set output.globalObject = "this" in webpack.umd.config.babel.js
30c840b 
fixes error with webpack umd output. see issue netlify#318
@hkennyv hkennyv mentioned this issue Jul 22, 2020
Merged
@hkennyv
Copy link
Contributor Author

hkennyv commented Jul 22, 2020 •
edited
Loading

It seems like it's an issue with the webpack.umd.config.js configuration. I set output.globalObject = "this" and rebuilt the package and it seems to fix it. I'm not sure why it only affects the latest version though since this config isn't any different than the one in the 1.6.0 version...

Following the issue on webpack here. It looks like they have a solution in the works as well.

I'm attaching a PR!

jlengstorf pushed a commit that referenced this issue Jul 29, 2020
@hkennyv
fix: ReferenceError: window is not defined (#319)
6a32436 
* set output.globalObject = "this" in webpack.umd.config.babel.js

fixes error with webpack umd output. see issue #318

* fix lint
@jlengstorf
Copy link
Contributor

just confirmed this working with v1.8.1 — let me know if you see any additional issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlengstorf @hkennyv