Skip to content

fix: ReferenceError: window is not defined #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2020
Merged

fix: ReferenceError: window is not defined #319

merged 2 commits into from
Jul 29, 2020

Conversation

hkennyv
Copy link
Contributor

@hkennyv hkennyv commented Jul 22, 2020

fixes error with webpack umd output. see issue #318

@netlify
Copy link

netlify bot commented Jul 22, 2020 •
edited
Loading

Deploy Success!

Built with commit 14740b1

https://deploy-preview-319--identity.netlify.app

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Jul 26, 2020
jlengstorf
jlengstorf approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirmed this working. thank you!

@jlengstorf jlengstorf merged commit 6a32436 into netlify:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlengstorf jlengstorf jlengstorf approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkennyv @jlengstorf @erezrokah