Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Add IngressLink support #58

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Add IngressLink support #58

merged 3 commits into from
Feb 19, 2021

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Add IngressLink support.
  • Add extraLabels support. It is an equivalent to controller.extraLabels from here as required for IngressLink to function.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley self-assigned this Feb 11, 2021
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Dean-Coakley

Please see my comments

@Dean-Coakley Dean-Coakley force-pushed the feat/kic-110-ingressLink branch from 6b8e5b3 to c7af792 Compare February 15, 2021 18:01
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! with a few minor doc issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants