This repository was archived by the owner on May 24, 2023. It is now read-only.
Fix Service to be an optional field. Add support for updating ExtraLabels. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug introduced in: 8238e10
Dean-Coakley
changed the title
pleshakov
reviewed
Feb 27, 2021
pleshakov
approved these changes
Mar 1, 2021
Dean-Coakley
force-pushed
the
fix/optional-svc
branch
from
0a4e1eb to
d19d549
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Servicewas added, but the generation of any KIC service depended on it existing, added a nil check to prevent panics: ad81ccfChecklist
Before creating a PR, run through this checklist and mark each as complete.