Update symbol package format and add Sourcelink #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -319,23 +319,12 @@ | |||
| <in> | |||
| <items> | |||
| <include name="${nuget.nupackages.dir}/*.nupkg"/> | |||
| <exclude name="${nuget.nupackages.dir}/*.symbols.nupkg"/> | |||
| </items> | |||
| </in> | |||
| <do> | |||
| <echo message="nuget push -source https://nuget.org/ ${path::get-file-name(filename)} ${environment::newline()}" file="${nuget.nupackages.pushbatfile}" append="true"/> | |||
There was a problem hiding this comment.
This url is not correct for pushing snupkg. They are ignored on it, even when explicitly pushing them.
I am going to PR the required url for pushing snupkg along with the regular package.
Seen after publishing NHibernate.Caches 5.6, done nhibernate/NHibernate-Caches#74 for fixing it there.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHibernate goes on building symbol.nupkg since v5.0 although they are no more consumable with library built from
Sdkprojects (new .csproj format).We should switch to building snupkg, and to ease furthermore debugging, add SourceLink as requested by #1971.
Fixes #1971.
Replaces #2018.