Skip to content

Fix nuget symbol push #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fredericDelaporte
Copy link
Member

They are pushed only with the v3 api url, see
https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg#publishing-a-symbol-package

Fix the #2019 PR which is in the same milestone.

@fredericDelaporte fredericDelaporte added this to the 5.3 milestone Aug 18, 2019
@hazzik
Copy link
Member

hazzik commented Aug 20, 2019

Should this go to 5.2.x?

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Aug 20, 2019

This would be useful if also back-porting #2019 to 5.2.x. 5.2.x does not support snupkg currently. Maybe were you willing to ask this on #2196, although #2196 does already target 5.2.x.

@hazzik
Copy link
Member

hazzik commented Aug 21, 2019

Never mind then

@fredericDelaporte fredericDelaporte merged commit 0ca3028 into nhibernate:master Aug 21, 2019
@fredericDelaporte fredericDelaporte deleted the FixSymbolPush branch August 21, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants