Support to-many relations in included resources. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this one? It looks like this is also the cause for nilportugues/laravel5-jsonapi#39. |
Nitpick-CI
reviewed
Mar 7, 2017
| $existingIndex = self::findIncludedIndex($data[JsonApiTransformer::INCLUDED_KEY], $arrayData[JsonApiTransformer::ID_KEY], $arrayData[JsonApiTransformer::TYPE_KEY]); | ||
| } | ||
| if ($existingIndex !== false) { | ||
| $data[JsonApiTransformer::INCLUDED_KEY][$existingIndex] = \array_filter(\array_merge($data[JsonApiTransformer::INCLUDED_KEY][$existingIndex], |
There was a problem hiding this comment.
Opening parenthesis of a multi-line function call must be the last content on the line
Nitpick-CI
reviewed
Mar 7, 2017
| } | ||
| if ($existingIndex !== false) { | ||
| $data[JsonApiTransformer::INCLUDED_KEY][$existingIndex] = \array_filter(\array_merge($data[JsonApiTransformer::INCLUDED_KEY][$existingIndex], | ||
| \array_filter($arrayData, self::filterEmptyArray())), self::filterEmptyArray()); |
There was a problem hiding this comment.
- Multi-line function call not indented correctly; expected 20 spaces but found 24
- Closing parenthesis of a multi-line function call must be on a line by itself
Nitpick-CI
reviewed
Mar 7, 2017
| if (!empty($data[JsonApiTransformer::INCLUDED_KEY])) { | ||
| $data[JsonApiTransformer::INCLUDED_KEY] = \array_values( | ||
| \array_unique($data[JsonApiTransformer::INCLUDED_KEY], SORT_REGULAR) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| protected static function filterEmptyArray() | ||
| { | ||
| return function($value) { |
There was a problem hiding this comment.
Expected 1 space after FUNCTION keyword; 0 found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue while using your awesome library.
It's currently not possible to include "to-many" relations that are defined in included resources. For example if you have Post and Comment objects like in your unit tests and you want to include an array of "likes" in the Comment object, these aren't included in the result.
Because this is my first pull request, I welcome all kinds of critique. ;)