-
Notifications
You must be signed in to change notification settings - Fork 2k
Add Alpine 3.16 variant #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine 3.16 variant #1729
Conversation
5505caa
to
d622b94
Compare
I don;'t think this should be done all in one shot because it might break people's build. We should be adding the version without changing the default |
I basically followed the commit from the previous Alpine version update (3760675), in which the default version also was updated immediately. Also I think updating default is a pretty reasonable thing to do (and is done by more official images), because if you need a specific OS version you probably should have already tagged it in your own pipeline, similar to using |
But this effectively drops support fort Alpine 3.14 for all version, forcing everyone who want a future security update in NOde, to also update their Alpine version |
Yeah, I think that's open to maintainers to decide how many OS versions you want to support. Alpine does still provide security support for 3.14 (and 3.13 even, see https://alpinelinux.org/releases/), so you might keep some more versions if preferred. Happy to adjust for that if wanted. |
Any consensus on this? 🤔 |
@LaurentGoderre see the previous discussion #1615 (comment) in that DockerHub doesn't want us supported more than 2 majors for Alpine at one time, so we dropped the oldest last time. @jnoordsij hold off on rebasing this for now, till #1733 (comment) lands |
Also remove Alpine 3.14
d622b94
to
23e032f
Compare
Saw #1733 just got merged, so rebased this. Let me know if anything else is needed. |
We need to ship 🚢 it asap 😀 |
Created PR on the official-images repo (docker-library/official-images#12596). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Description
Adds latest Alpine version (3.16) and removes oldest one. Fixes #1728.
Motivation and Context
Provide latest Alpine version (see https://alpinelinux.org/posts/Alpine-3.16.0-released.html)
Testing Details
Example Output(if appropriate)
Types of changes
Checklist