Skip to content

Add Alpine 3.16 variant #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Add Alpine 3.16 variant #1729

merged 1 commit into from
Jun 7, 2022

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented May 24, 2022

Description

Adds latest Alpine version (3.16) and removes oldest one. Fixes #1728.

Motivation and Context

Provide latest Alpine version (see https://alpinelinux.org/posts/Alpine-3.16.0-released.html)

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@jnoordsij jnoordsij force-pushed the add-alpine-3.16 branch 2 times, most recently from 5505caa to d622b94 Compare May 24, 2022 13:52
@LaurentGoderre
Copy link
Member

I don;'t think this should be done all in one shot because it might break people's build. We should be adding the version without changing the default

@jnoordsij
Copy link
Contributor Author

I basically followed the commit from the previous Alpine version update (3760675), in which the default version also was updated immediately.

Also I think updating default is a pretty reasonable thing to do (and is done by more official images), because if you need a specific OS version you probably should have already tagged it in your own pipeline, similar to using latest vs. a specific version.

@LaurentGoderre
Copy link
Member

But this effectively drops support fort Alpine 3.14 for all version, forcing everyone who want a future security update in NOde, to also update their Alpine version

@jnoordsij
Copy link
Contributor Author

Yeah, I think that's open to maintainers to decide how many OS versions you want to support. Alpine does still provide security support for 3.14 (and 3.13 even, see https://alpinelinux.org/releases/), so you might keep some more versions if preferred. Happy to adjust for that if wanted.

@bricss
Copy link

bricss commented Jun 2, 2022

Any consensus on this? 🤔

@nschonni
Copy link
Member

nschonni commented Jun 5, 2022

@LaurentGoderre see the previous discussion #1615 (comment) in that DockerHub doesn't want us supported more than 2 majors for Alpine at one time, so we dropped the oldest last time.

@jnoordsij hold off on rebasing this for now, till #1733 (comment) lands

Also remove Alpine 3.14
@jnoordsij
Copy link
Contributor Author

@LaurentGoderre see the previous discussion #1615 (comment) in that DockerHub doesn't want us supported more than 2 majors for Alpine at one time, so we dropped the oldest last time.

@jnoordsij hold off on rebasing this for now, till #1733 (comment) lands

Saw #1733 just got merged, so rebased this. Let me know if anything else is needed.

@bricss
Copy link

bricss commented Jun 7, 2022

We need to ship 🚢 it asap 😀

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Created PR on the official-images repo (docker-library/official-images#12596). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@jnoordsij jnoordsij deleted the add-alpine-3.16 branch June 8, 2022 10:25
@jnoordsij jnoordsij mentioned this pull request Nov 23, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS images based on Alpine 3.16
4 participants