Skip to content

Add Alpine 3.17 variant #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Add Alpine 3.17 variant #1813

merged 1 commit into from
Dec 11, 2022

Conversation

jnoordsij
Copy link
Contributor

Description

Adds latest Alpine version (3.17) and removes oldest one (3.15).
See also #1729.

Motivation and Context

Provide latest Alpine version (see https://alpinelinux.org/posts/Alpine-3.17.0-released.html).

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@jnoordsij
Copy link
Contributor Author

Side note: a major change in Alpine 3.17 is OpenSSL 3.0 being the new default version. As builds are passing, this is most likely not an issue, but I'm not sure how to test for possible complications on older Node versions.

@bricss
Copy link

bricss commented Nov 29, 2022

All those complications gotta be mostly related to the TLS and certificates verification, but it's all up to applications devs to tackle on those issues, e.g.: UnsafeLegacyRenegotiation 🤗

Also remove Alpine 3.15
@jnoordsij
Copy link
Contributor Author

Rebased onto master. Let me know if there's anything else needed to get this merged!

@bricss
Copy link

bricss commented Dec 1, 2022

Hope this PR will manage it into the main/master soon 🥌 LFTI 🔭

@vincsb
Copy link

vincsb commented Dec 5, 2022

Any news?

@bricss
Copy link

bricss commented Dec 5, 2022

Can someone just force ⚡ push it into the main? 😄

@github-actions
Copy link

Created PR on the official-images repo (docker-library/official-images#13716). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@ttshivers
Copy link
Member

Looks fine to me and all the checks are passing.

@ttshivers
Copy link
Member

ttshivers commented Dec 12, 2022

@jnoordsij this appears to be failing tests at docker-library/official-images#13716. Can you take a look or we might want to revert?

@jnoordsij jnoordsij deleted the add-alpine-3.17 branch December 12, 2022 06:56
@jnoordsij
Copy link
Contributor Author

@ttshivers I opened #1820 to fix the builds

@vincsb
Copy link

vincsb commented Dec 12, 2022

Thanks!

@jnoordsij jnoordsij mentioned this pull request May 10, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants