Skip to content

add new lines to ends of all files #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

apapirovski
Copy link
Contributor

What it says...

You get a new line and you get a new line... eeeeeverybody gets a new line.

@codecov-io
Copy link

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          13       13           
  Lines         444      444           
=======================================
  Hits          424      424           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b97b984...49ac19b. Read the comment docs.

Copy link
Contributor

@priyank-p priyank-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Just one suggestion can you add a note about EOL in CONTRIBUTING.md somewhere.

Copy link
Contributor

@Tiriel Tiriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung
Copy link
Member

joyeecheung commented Nov 5, 2017

@cPhost A better way would be to use eslint plugins to check JSONs..

EDIT: OK there are also markdowns, hmm

@joyeecheung
Copy link
Member

BTW I think this is good to merge, but @apapirovski you can decide if you want to do it here or open another one. I've sent you collaborator invites, feel free to merge this yourself!

@priyank-p
Copy link
Contributor

@joyeecheung i will open an issue and look into the eslint json plugin.

@apapirovski
Copy link
Contributor Author

I tried using the eslint json plugin out there when I made this. It didn't seem to really validate this type of thing though :| Not sure what can be done... On Node core we just check this as part of the review flow and request changes.

@apapirovski apapirovski merged commit 254462e into nodejs:master Nov 5, 2017
@apapirovski apapirovski deleted the patch-new-lines branch November 5, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants