-
Notifications
You must be signed in to change notification settings - Fork 115
add new lines to ends of all files #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 13 13
Lines 444 444
=======================================
Hits 424 424
Misses 20 20 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Just one suggestion can you add a note about EOL in CONTRIBUTING.md somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cPhost A better way would be to use eslint plugins to check JSONs.. EDIT: OK there are also markdowns, hmm |
BTW I think this is good to merge, but @apapirovski you can decide if you want to do it here or open another one. I've sent you collaborator invites, feel free to merge this yourself! |
@joyeecheung i will open an issue and look into the eslint json plugin. |
I tried using the eslint json plugin out there when I made this. It didn't seem to really validate this type of thing though :| Not sure what can be done... On Node core we just check this as part of the review flow and request changes. |
What it says...