Skip to content

add new lines to ends of all files #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,4 @@ By making a contribution to this project, I certify that:
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
this project or the open source license(s) involved.
2 changes: 1 addition & 1 deletion test/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
"node": true,
"mocha": true
}
}
}
2 changes: 1 addition & 1 deletion test/fixtures/collaborators.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
"email": "[email protected]",
"type": "COLLABORATOR"
}
]
]
2 changes: 1 addition & 1 deletion test/fixtures/comments_with_ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
"publishedAt": "2017-10-22T04:16:36.458Z",
"bodyText": "Linter CI: https://ci.nodejs.org/job/node-test-linter/13127/"
}
]
]
2 changes: 1 addition & 1 deletion test/fixtures/comments_with_lgtm.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
"author": {
"login": "bar"
}
}]
}]
2 changes: 1 addition & 1 deletion test/fixtures/odd_commits.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,4 @@
"authoredByCommitter": false
}
}
]
]
2 changes: 1 addition & 1 deletion test/fixtures/op_html.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"<p>The npm install rules had a hidden dependency on the <code>node</code> binary<br>\ninstall rule creating the <code>$PREFIX/bin</code> directory.</p>\n<p>Because with <code>./configure --shared</code> no binary is created, the rule<br>\nsubsequently failed. Fix that by creating the directory before<br>\ncreating the symlinks to the npm and npx scripts.</p>\n<p>(Whether it makes sense to install npm without a <code>node</code> binary is<br>\na separate question. This commit is not taking positions. :-))</p>\n<p>Regression introduced in commit <a href=\"https://github.com/nodejs/node/commit/ed8c89a07d159b72a2e351a76c92b8b6a15515bd\" class=\"commit-link\"><tt>ed8c89a</tt></a> (\"build: fix shared installing<br>\ntarget\") which, as the commit log indicates, was itself a bug fix for<br>\nthe <code>./configure --shared</code> install.</p>\n<p>Fixes: <a href=\"https://github.com/nodejs/node/issues/16437\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"267969588\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16437\">#16437</a><br>\nRefs: <a href=\"https://github.com/nodejs/node/pull/15148\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"254809069\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/15148\">#15148</a></p>",
"<p>Refs: <a href=\"https://github.com/nodejs/node/pull/16293\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"266519190\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16293\">#16293</a></p>\n<h5>Checklist</h5>\n\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n<h5>Affected core subsystem(s)</h5>\n\n<p>vm</p>",
"<p>Included reference to \\'constant time\\' in crypto.timingSafeEqual description</p>\n<p><span aria-label=\"This pull request closes issue #16504.\" class=\"issue-keyword tooltipped tooltipped-se\">Fixes</span> : <a href=\"https://github.com/nodejs/node/issues/16504\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"268571876\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16504\">#16504</a></p>"
]
]
2 changes: 1 addition & 1 deletion test/fixtures/pr_with_fixes_and_refs.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
}
]
}
}
}
2 changes: 1 addition & 1 deletion test/fixtures/reviewers_approved.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@
"source": "comment"
}
}
]
]
2 changes: 1 addition & 1 deletion test/fixtures/reviewers_rejected.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@
"source": "review"
}
}
]
]
2 changes: 1 addition & 1 deletion test/fixtures/reviews_approved.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@
},
"url": "https://github.com/nodejs/node/pull/16438#pullrequestreview-71839232",
"publishedAt": "2017-10-24T19:21:52Z"
}]
}]
2 changes: 1 addition & 1 deletion test/fixtures/reviews_rejected.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@
},
"url": "https://github.com/nodejs/node/pull/16438#pullrequestreview-71482624",
"publishedAt": "2017-10-24T11:27:02Z"
}]
}]
2 changes: 1 addition & 1 deletion test/fixtures/simple_commits.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
"authoredByCommitter": true
}
}
]
]