Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Stubs in core/numerictypes.pyi are not picked up #65

Closed
person142 opened this issue Apr 21, 2020 · 0 comments · Fixed by #83
Closed

Stubs in core/numerictypes.pyi are not picked up #65

person142 opened this issue Apr 21, 2020 · 0 comments · Fixed by #83
Assignees
@person142
Labels
bug good first issue
Milestone
before-merging-in...

Comments

@person142
Copy link
Member

This is the same issue as #50, but for core/numerictypes.pyi. The stubs are not imported into __init__.pyi, so they are not picked up. A quick test of that:

import numpy as np

reveal_type(np.maximum_sctype(np.dtype(np.float64)))

gives Revealed type is 'Any' on master. We should move those stubs into the top-level __init__.pyi and add tests.
@person142 person142 added this to the before-merging-into-numpy milestone May 24, 2020
@person142 person142 self-assigned this May 24, 2020
person142 added a commit to person142/numpy-stubs that referenced this issue May 24, 2020
@person142
MAINT: pick up types from core/numerictypes.pyi
2a1df12 
Closes numpy#65.

The types currently aren't picked up. Fix that by moving them into
`__init__.pyi` along with the rest of the types. While we are at it,
polish the signatures a bit and add tests.
@person142 person142 mentioned this issue May 24, 2020
Merged
person142 added a commit that referenced this issue Jun 5, 2020
@person142
MAINT: pick up types from core/numerictypes.pyi (#83)
1eaccd4 
Closes #65.

The types currently aren't picked up. Fix that by moving them into
`__init__.pyi` along with the rest of the types. While we are at it,
polish the signatures a bit and add tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@person142 person142

Labels
bug good first issue
Projects
None yet
Milestone
before-merging-into-numpy
Development

Successfully merging a pull request may close this issue.

MAINT: pick up types from core/numerictypes.pyi person142/numpy-stubs
1 participant
@person142