This repository was archived by the owner on Jun 10, 2020. It is now read-only.
MAINT: pick up types from core/numerictypes.pyi
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes numpy#65. The types currently aren't picked up. Fix that by moving them into `__init__.pyi` along with the rest of the types. While we are at it, polish the signatures a bit and add tests.
|
Unless someone objects, I will merge this in a couple of days. (I don't want to port this unconnected file to NumPy.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65.
The types currently aren't picked up. Fix that by moving them into
__init__.pyialong with the rest of the types. While we are at it,polish the signatures a bit and add tests.