Skip to content

programs.shfmt.indent_size breaks shfmt config #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sellout opened this issue Jul 31, 2023 · 0 comments · Fixed by #97
Closed

programs.shfmt.indent_size breaks shfmt config #96

sellout opened this issue Jul 31, 2023 · 0 comments · Fixed by #97
Labels
bug Something isn't working

Comments

@sellout
Copy link
Contributor

sellout commented Jul 31, 2023

Passing any formatting option to shfmt causes it to ignore the EditorConfig-based formatting config (see “If any parser or printer flags are given to the tool, no EditorConfig files will be used” in the README.

treefmt-nix will always pass -i to shfmt, causing it to ignore the actual configuration. There is no option to “unset” programs.shfmt.indent_size.

I think indent_size should allow (and default to) null, only passing -i if explicitly requested.
@sellout sellout added the bug Something isn't working label Jul 31, 2023
sellout added a commit to sellout/bash-strict-mode that referenced this issue Jul 31, 2023
@sellout
Appease the new formatter
f7f1b14 
Which currently misbehaves because of numtide/treefmt-nix#96.
sellout added a commit to sellout/bash-strict-mode that referenced this issue Jul 31, 2023
@sellout
Appease the new formatter
45b9d98 
Which currently misbehaves because of numtide/treefmt-nix#96.
sellout added a commit to sellout/bash-strict-mode that referenced this issue Jul 31, 2023
@sellout
Appease the new formatter
300e3a5 
Which currently misbehaves because of numtide/treefmt-nix#96.
sellout added a commit to sellout/bash-strict-mode that referenced this issue Jul 31, 2023
@sellout
Appease the new formatter
dc339b9 
Which currently misbehaves because of numtide/treefmt-nix#96.
@sellout sellout mentioned this issue Jul 31, 2023
Merged
@RossSmyth RossSmyth mentioned this issue Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow indent_size to be unset for shfmt
1 participant
@sellout