Skip to content

Allow indent_size to be unset for shfmt #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2023
Merged

Allow indent_size to be unset for shfmt #97

merged 2 commits into from
Aug 1, 2023

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Jul 31, 2023

So the defaults don’t get in the way of reading the config file.

Fixes #96.

@sellout
Allow indent_size to be unset for shfmt
314de2a 
So the defaults don’t get in the way of reading the config file.
zimbatm
zimbatm reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. after this round of review, it should be ready to merge.

@sellout
Revert the breaking change
3f27156 
Also add some explanation and simplify a conditional.
@sellout
Copy link
Contributor Author

sellout commented Aug 1, 2023

Updated!

@zimbatm zimbatm merged commit de03b21 into numtide:main Aug 1, 2023
@zimbatm
Copy link
Member

zimbatm commented Aug 1, 2023

thanks!

Mic92 pushed a commit that referenced this pull request Aug 12, 2023
@sellout @Mic92
Allow indent_size to be unset for shfmt (#97)
a60a210 
* Allow indent_size to be unset for shfmt

So the defaults don’t get in the way of reading the config file.

* Revert the breaking change

Also add some explanation and simplify a conditional.
o-az pushed a commit to unionlabs/treefmt-nix that referenced this pull request Jan 26, 2024
@sellout @o-az
Allow indent_size to be unset for shfmt (numtide#97)
751dd45 
* Allow indent_size to be unset for shfmt

So the defaults don’t get in the way of reading the config file.

* Revert the breaking change

Also add some explanation and simplify a conditional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

programs.shfmt.indent_size breaks shfmt config
2 participants
@sellout @zimbatm