Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancel screen.waitFor if needed #241

Closed
afzaalahmad opened this issue Jun 24, 2021 · 1 comment · Fixed by #243
Closed

cancel screen.waitFor if needed #241

afzaalahmad opened this issue Jun 24, 2021 · 1 comment · Fixed by #243
Assignees
@s1hofmann

Comments

@afzaalahmad
Copy link

Description
I am using screen.waitFor to find elements on screen.waitFor with some time. Since, this operation is cpu intensive, I want to cancel the waitFor if at any point I figure that it is unnecessary waitFor down the lane.
@afzaalahmad
Copy link
Author

@s1hofmann @svettwer can you please review it? I've opened a Pull Request for this enhancement.

s1hofmann added a commit that referenced this issue Jun 24, 2021
@s1hofmann
(#241) Added node-abort-controller
14b70f3
s1hofmann added a commit that referenced this issue Jun 24, 2021
@s1hofmann
(#241) Finally renamed timout files and made timeout cancellable
6c9de33
s1hofmann added a commit that referenced this issue Jun 24, 2021
@s1hofmann
(#241) Made Screen#waitFor cancellable
b554233
s1hofmann added a commit that referenced this issue Jun 24, 2021
@s1hofmann
(#241) Added abort signal to OptionalSearchParameters
3aa660c
s1hofmann added a commit that referenced this issue Jun 24, 2021
@s1hofmann
(#241) Updated docs
605d7d5
@s1hofmann s1hofmann linked a pull request Jun 24, 2021 that will close this issue
Closing #241 #243
Merged
@s1hofmann s1hofmann self-assigned this Jun 24, 2021
s1hofmann added a commit that referenced this issue Jun 25, 2021
@s1hofmann
Merge pull request #243 from nut-tree/feature/241/cancel_waitfor
dbbbc09 
Closing #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1hofmann s1hofmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closing #241 nut-tree/nut.js
2 participants
@s1hofmann @afzaalahmad