Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing #241 #243

Merged
merged 5 commits into from
Jun 25, 2021
Merged

Closing #241 #243

merged 5 commits into from
Jun 25, 2021

Conversation

s1hofmann
Copy link
Member

This PR introduces an AbortSignal as additional search parameter.
Similar to what's already known from e.g. the fetch API in browsers, waitFor will from now on be cancellable using node-abort-controller

@s1hofmann s1hofmann added the enhancement Enhancement to existing features label Jun 24, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.8% 97.8% Coverage
0.0% 0.0% Duplication

@s1hofmann s1hofmann linked an issue Jun 24, 2021 that may be closed by this pull request
Copy link
Contributor

@svettwer svettwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 👍

@s1hofmann s1hofmann merged commit dbbbc09 into develop Jun 25, 2021
@s1hofmann s1hofmann deleted the feature/241/cancel_waitfor branch June 25, 2021 09:41
@afzaalahmad
Copy link

@s1hofmann nicely done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cancel screen.waitFor if needed
3 participants