(#202) Install @nut-tree/libnut@next #207
Conversation
| - name: Install @nut-tree/libnut@next | ||
| run: npm i @nut-tree/libnut@next |
There was a problem hiding this comment.
Is it intended to only install @nut-tree/libnut@next in the test job?
As the changes are not committed as far as I can see, the checkout action in line 45 would not consider the change.
In addition, even if a publish would consider @nut-tree/libnut@next it would fail from my perspective as the installation during the ci process would change the package-lock.json and publishing with uncommitted changes is not allowed. To be honest, I'm not sure if there is a switch to change that. 🤔
I'd recommend to add the next version of libnut to the package.json instead of installing it during CI.
There was a problem hiding this comment.
Is it intended to only install @nut-tree/libnut@next in the test job?
Argh, too many jobs I recently updated. No, that went unnoticed.
during the ci process would change the package-lock.json and publishing with uncommitted changes is not allowed
npm does not care about a dirty working tree and package-lock.json files are never published, so that's no problem.
I'd recommend to add the next version of libnut to the package.json instead of installing it during CI.
This would require knowledge about the last published snapshot version of @nut-tree/libnut.
Running npm i @nut-tree/libnut@next simply installs the latest snapshot under the @next tag.
There was a problem hiding this comment.
hmhmh 🤔
you could just add the following to package.json
"dependencies": {
"@nut-tree/libnut": "next",
"clipboardy": "2.0.0",
"opencv4nodejs-prebuilt": "5.3.0-2"
},if the next version is tagged correctly, no further info is required.
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.