Skip to content

(#202) Install @nut-tree/libnut@next #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2021
Merged

(#202) Install @nut-tree/libnut@next #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2077dad
(#202) Install @nut-tree/libnut@next
s1hofmann Jan 25, 2021
3f4a7f4
(#202) Install @nut-tree/libnut@next during deploy job as well
s1hofmann Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/snapshot_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
docker run -it -d --name nut-ci --shm-size 4gb --user $(id -u):$(id -g) -v ${PWD}:${PWD}:rw s1hofmann/nut-ci:latest bash
- name: Install
run: npm ci
- name: Install @nut-tree/libnut@next
run: npm i @nut-tree/libnut@next
Comment on lines +28 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to only install @nut-tree/libnut@next in the test job?
As the changes are not committed as far as I can see, the checkout action in line 45 would not consider the change.
In addition, even if a publish would consider @nut-tree/libnut@next it would fail from my perspective as the installation during the ci process would change the package-lock.json and publishing with uncommitted changes is not allowed. To be honest, I'm not sure if there is a switch to change that. 🤔

I'd recommend to add the next version of libnut to the package.json instead of installing it during CI.

Copy link
Member Author

@s1hofmann s1hofmann Jan 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to only install @nut-tree/libnut@next in the test job?

Argh, too many jobs I recently updated. No, that went unnoticed.

during the ci process would change the package-lock.json and publishing with uncommitted changes is not allowed

npm does not care about a dirty working tree and package-lock.json files are never published, so that's no problem.

I'd recommend to add the next version of libnut to the package.json instead of installing it during CI.

This would require knowledge about the last published snapshot version of @nut-tree/libnut.
Running npm i @nut-tree/libnut@next simply installs the latest snapshot under the @next tag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmhmh 🤔
you could just add the following to package.json

  "dependencies": {
    "@nut-tree/libnut": "next",
    "clipboardy": "2.0.0",
    "opencv4nodejs-prebuilt": "5.3.0-2"
  },

if the next version is tagged correctly, no further info is required.

- name: Compile
run: npm run compile
- name: Init e2e test subpackage
Expand All @@ -48,6 +50,8 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: 14
- name: Install @nut-tree/libnut@next
run: npm i @nut-tree/libnut@next
- name: Publish snapshot release
run: bash ./.build/pre-release.sh
env:
Expand Down