Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/455/non image find #461

Merged
merged 16 commits into from
Jan 9, 2023
Merged

Feature/455/non image find #461

merged 16 commits into from
Jan 9, 2023

Conversation

s1hofmann
Copy link
Member

Closing #455

s1hofmann added 16 commits January 6, 2023 22:49
@s1hofmann
(#455) Made MatchRequest class generic to allow for generic needle ty…
163dbce 
…pes as well as additional generic provider data that gets passed to the provider implementation
@s1hofmann
(#455) BREAKING: Remove both searchMultipleScales and confidence from…
4e3b180 
… OptionalSearchParameters since these properties would be provider specific and should be handled via providerData
@s1hofmann
(#455) Handle generic provider data in ImageFinder interface
106209a
@s1hofmann
(#455) New query types to enable searching for things other than images
a3a2f05
@s1hofmann
(#455) New interfaces to search for text or windows
b0026d9
@s1hofmann
(#455) Added new provider interfaces to registry, changed log level o…
e6d6f0f 
…f register events to trace
@s1hofmann
(#455) Revert removing confidence property from OptionalSearchParameters
c6bc38a
@s1hofmann
(#455) Extended find implementation conforms all existing tests
2de9643
@s1hofmann
(#455) Increase coverage
d66dffc
@s1hofmann
(#455) Allow broader input on toShow jest matcher
eba13ba
@s1hofmann
(#455) Refactor handling of finder implementations, add tests
1d78e2e
@s1hofmann
(#455) Added tests for different find queries
a28a734
@s1hofmann
(#455) Added find input validation and tests
4fbc167
@s1hofmann
(#455) Query tests
103f226
@s1hofmann
(#455) Tests for DefaultProviderRegistry
7c120e8
@s1hofmann
(#455) Remove commented lines
6757d10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

83.1% 83.1% Coverage
0.0% 0.0% Duplication

@s1hofmann s1hofmann merged commit c619f02 into develop Jan 9, 2023
@s1hofmann s1hofmann deleted the feature/455/non-image-find branch January 9, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s1hofmann