-
Notifications
You must be signed in to change notification settings - Fork 256
New feature: indent guides #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's definitively worth having. I would prefer they be a component that people can add to their renderers. Is that how you have done this? |
It's possible, but I need to add new fields to the node (for example I use fields from local nodeData = {
id = item.id,
name = item.name,
type = item.type,
loaded = item.loaded,
indent = node_indent,
extra = item.extra,
path = item.path,
ext = item.ext,
search_pattern = item.search_pattern,
+ level = level,
+ is_last = i == #source_items,
} |
The hard part about this is to make it in a way that is open ended and configurable. Here is what I am thinking right now:
Then I (as an end user) can tweak it in any way I want to change the amount of indent or add any style of markers. How does that sound? |
... and your specific config there could be an example in the README or the wiki. |
I think this is the best option. I will create a pull request with indent guides this week. |
I've added this feature in #107. |
Great! Can't believe that this is about to be added :) |
Co-authored-by: Daniil Shvalov <[email protected]>
Add the ability to enable indent guides like this:
I have some developments, so I can open a pull request, if you think it's worth adding this feature.
The text was updated successfully, but these errors were encountered: