-
Notifications
You must be signed in to change notification settings - Fork 256
feat: indent guides #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: indent guides #107
Conversation
No problem at all, we all have lives outside of open source contributions! Thanks for submitting, I'll review soon. |
Co-authored-by: cseickel <[email protected]>
Co-authored-by: cseickel <[email protected]>
Co-authored-by: cseickel <[email protected]>
I have simplified the code. |
Thanks for making those changes. While testing ti out I realized there is one major item we forgot about:
I think it needs to be changed to this method of configuration to make it easier to configure and prevent breaking changes. With this strategy, the If you are short on time I can make these changes before merging, just let me know. |
I have added a global configuration implementation. Now the user can globally configure any component. If the user manually changed the component, the configuration will be overridden (local configuration is more significant than the global one). For example, user can configure icons: require("neo-tree").setup({
icon_renderer = {
folder_closed = "-",
},
-- other configurations
}) |
I really like the idea of having a global config and we should definitely do that. What this still doesn't address is the fact that it is a breaking change to take an implicit component and turn it into an explicit one. Everyone that has applied any customization to their renderers will suddenly lose indents with this update, To prevent that, we have to either:
Number two fits better with what you have now. It can probably happen in the |
Hey @danilshvalov, I'm going to finish this up and merge it. The only outstanding issue was ensuring the component is always implicitly added even if the users have a custom renderer without an indent component. |
Oops, didn't mean to close it. |
Content moved to #131 so I could squash and rebase. |
I'm sorry for the delay. There wasn't enough time to finish.