[CommandBuffer] Make double finalizing fail #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
conformance
EwanC
reviewed
Nov 14, 2024
github-actions
bot
added
specification
EwanC
reviewed
Nov 14, 2024
hdelan
force-pushed
the
double-finalize
branch
from
5268870 to
0a75eef
Compare
EwanC
reviewed
Nov 14, 2024
aarongreig
approved these changes
Nov 15, 2024
hdelan
force-pushed
the
double-finalize
branch
from
df0961e to
d474590
Compare
EwanC
approved these changes
Nov 15, 2024
hdelan
force-pushed
the
double-finalize
branch
from
d474590 to
7be4528
Compare
|
Can you whack a link to the DPC++ PR for this in the description, ta |
|
@hdelan This PR is next in the queue to be merged, could you resolve the conflict? |
Hugh is on holiday until Monday, so might be better to jump to another ready-to-merge PR until then |
hdelan
force-pushed
the
double-finalize
branch
from
7be4528 to
3352387
Compare
|
Have rebased |
|
@hdelan there's a failing command buffer test, just checking this is expected before this can be merged? |
|
The error given is: Which I reckon is due to old/incompatible drivers on the runner. I'll kick it off again and see if it passes. |
hdelan
force-pushed
the
double-finalize
branch
3 times, most recently
from
fb31b89 to
830a6c9
Compare
A command buffer should fail if finalize is called multiple times on the same command buffer. This matches openCL behaviour.
hdelan
force-pushed
the
double-finalize
branch
from
830a6c9 to
69b0e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A command buffer should fail if finalize is called multiple times on the same command buffer. This matches openCL behaviour.
DPC++ PR: intel/llvm#16097