Skip to content

feat: implement multi provider #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

feat: implement multi provider #645

wants to merge 28 commits into from

Conversation

bbland1
Copy link
Contributor

@bbland1 bbland1 commented Mar 6, 2025 •
edited
Loading

This PR

Related Issues

Fixes #599

Notes

I know @jblacker worked on implementing the strategies and made a PR #668 so I don’t know how they overlap with what I have here so far. I know this is in progress so I don’t think it is ready to be fully reviewed yet.

Follow-up Tasks

  • the evaluation methods need to be implemented using the strategy
  • hooks need to be finished to be implemented
  • the strategies need to be built
  • events needs to be implemented

How to test

@bbland1 bbland1 changed the title 599/implement multi provider feat:implement multi provider Mar 6, 2025
@bbland1 bbland1 changed the title feat:implement multi provider feat: implement multi provider Mar 6, 2025
bbland1 and others added 20 commits March 8, 2025 18:40
@bbland1
feat(multi-provider): set up multi-provider directory
089c098 
Signed-off-by: bbland1 <[email protected]>
@bbland1
feat: set up func to create new multiprovider & register passed provi…
b8275df 
…ders

Signed-off-by: bbland1 <[email protected]>
@bbland1
feat: added Metadata Method to the multiprovider
6ef2dd8 
Signed-off-by: bbland1 <[email protected]>
@bbland1
feat: added the based of the Init method that will process the inital…
63a5300 
…ize of the providers

Signed-off-by: bbland1 <[email protected]>
@bbland1
moved providers into pkg directory
ac9ab37 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added Init method to handle any providers with intialization
65e2f04 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added the Shutdown method
dd933fb 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added getter methods to the unexported fields
32af790 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added tests to check unique name for providers passed
c6aaf74 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test checking if error thrown for unique name if not unique
70878e5 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test to check for metadata, currently fails
d5f3d6a 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test for getter methods of the struct provider entries
a3ba348 
Signed-off-by: bbland1 <[email protected]>
@cupofcat @bbland1
chore(flagd): Updates flagd core to v0.11.2 (open-feature#636)
efa68b9 
Signed-off-by: Maks Osowski <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@cupofcat @bbland1
feat(flagd): Added WithGrpcDialOptionsOverride provider option (open-…
0ac6343 
…feature#638)

Signed-off-by: Maks Osowski <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@github-actions @bbland1
chore(main): release providers/flagd 0.2.6 (open-feature#635)
270f5e5 
Signed-off-by: OpenFeature Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: bbland1 <[email protected]>
@toddbaert @aimuz @bbland1
fix(deps): Remove dependency on sigs.k8s.io/controller-runtime/pkg/lo… (
0067b34 
open-feature#639)

Signed-off-by: aimuz <[email protected]>
Co-authored-by: aimuz <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@thomaspoignant @bbland1
chore(go-feature-flag): Support new hook format (open-feature#641)
4e259c6 
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@github-actions @bbland1
chore(main): release providers/go-feature-flag 0.2.4 (open-feature#643)
e225fbd 
Signed-off-by: OpenFeature Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test for MP Init method with mock providers that have Init methods
ac2f314 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added shutdown test confirming method run in MP when called
2d6f44b 
Signed-off-by: bbland1 <[email protected]>
@bbland1 bbland1 force-pushed the 599/implement-multi-provider branch from c3f9e57 to 2d6f44b Compare March 8, 2025 23:40
@github-actions github-actions bot requested a review from toddbaert March 8, 2025 23:40
@bbland1
Copy link
Contributor Author

bbland1 commented Mar 28, 2025

I am still working on this I have been a bit under the weather recently

@jblacker
Copy link
Contributor

jblacker commented Apr 7, 2025

@bbland1 I'd love to help out on this. I need to use this for a few projects and rather contribute here than rolling my own. Personally I would only need the "First Match" strategy, but happy to work on whatever. If I don't hear back I'll pull this into my fork to begin working on implementing that strategy.

@bbland1
Copy link
Contributor Author

bbland1 commented Apr 7, 2025

@jblacker I'd appreciate the help. I was working through the provider and I got a bit sick 😅. I’m working on getting the evaluation methods of the multiproivder tonight so the required parts should be there.

I haven't delved too much into the strategies yet but I was planning to have a strategies directory and have a BaseEvaluation then start the FirstMatch to extend that. If you re still down for it, thanks!

@jblacker
Copy link
Contributor

jblacker commented Apr 8, 2025 •
edited
Loading

On it! Hope you're feeling better!

@jblacker
Copy link
Contributor

jblacker commented Apr 9, 2025

If you take a look at my fork I have the FirstMatch strategy completed. I'm going to take a shot at FirstSuccess as well before I open a PR

bbland1 added 3 commits April 9, 2025 15:53
@bbland1
added a func to determine which eval strategy to use and added it to …
cbdbcc3 
…where it should be when strategies pushed

Signed-off-by: bbland1 <[email protected]>
@bbland1
creating the base of a base strategy similar to js version that can b…
28efb9f 
…e used to define custom strategies

Signed-off-by: bbland1 <[email protected]>
@bbland1
fleshing out the BaseStrategy to have the help funcs to be used in st…
e52cd9c 
…rategies similar to TS and passing that type into the provider

Signed-off-by: bbland1 <[email protected]>
@jblacker
Copy link
Contributor

I ended up implementing the rest of the provider since I needed to use it in another project. The PR is open @ #669. I did not implement hooks or eventing yet if you want to take that on from my fork.

@bbland1
Copy link
Contributor Author

bbland1 commented Apr 24, 2025

@jblacker I just saw that PR, I’ll have to look it over and maybe I can help with the hooks. I know you needed it for a project but I appreciate the work on it and using this branch to push it forward.

@beeme1mr
Copy link
Member

Closing in favor of #669. Thanks for kicking it off @bbland1! 🎉

@beeme1mr beeme1mr closed this Apr 26, 2025
@bbland1 bbland1 deleted the 599/implement-multi-provider branch April 26, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl Awaiting requested review from bacherfl

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees

@bacherfl bacherfl

@Kavindu-Dodan Kavindu-Dodan

@thomaspoignant thomaspoignant

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Multi-Provider
8 participants
@bbland1 @jblacker @beeme1mr @bacherfl @Kavindu-Dodan @thomaspoignant @toddbaert @cupofcat