feat: Implement Multiprovider #668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bbland1 <[email protected]>
…ders Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
…ize of the providers Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: Maks Osowski <[email protected]> Signed-off-by: bbland1 <[email protected]>
…feature#638) Signed-off-by: Maks Osowski <[email protected]> Signed-off-by: bbland1 <[email protected]>
Signed-off-by: OpenFeature Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: bbland1 <[email protected]>
open-feature#639) Signed-off-by: aimuz <[email protected]> Co-authored-by: aimuz <[email protected]> Signed-off-by: bbland1 <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: bbland1 <[email protected]>
Signed-off-by: OpenFeature Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
…r struct made Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
Signed-off-by: bbland1 <[email protected]>
…where it should be when strategies pushed Signed-off-by: bbland1 <[email protected]>
…e used to define custom strategies Signed-off-by: bbland1 <[email protected]>
…rategies similar to TS and passing that type into the provider Signed-off-by: bbland1 <[email protected]>
Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Raphael Wigoutschnigg <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
- Rename UniqueNameProvider -> NamedProvider: More accurate description of type as it's not enforced - Updated signature of NewMultiProvider function: Using a map enforces unique names, use options pattern & config object for future extension - Relocated NamedProvider to strategies as it's not needed externally - Update shape of MultiProvider: Added logging, made all fields private, used map internally - Moved aggregate-errors into errors package - Added alias for ProviderMap shape & added helper functions - Use pointers since we're passing stuff around and want to avoid unnecessary clones of objects & extra garbage collection - Updated other various signatures throughout as needed - Update tests & remove tests that no longer apply Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Also fixed some synchronization issues while I was at it Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
- Rewrote using multiple go-routines & channels instead of a mutex - Added tests - Added timeout functionality & option Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
Signed-off-by: Jordan Blacker <[email protected]>
jblacker
force-pushed
the
599/implement-multi-provider
branch
from
c61f457 to
ff0f81f
Compare
|
Closing due to the branch being screwy. Reopened as #669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds an implementation of multi-provider for combining multiple providers into a single provider.
Related Issues
Implements #599
Notes
I implemented this based on the JavaScript version of the OpenFeature SDK. More strategies can be added at any time. Additionally, I branched off of @bbland1 so some of their commits are also part of this branch.
Follow-up Tasks
How to test
Create multiple
FeatureProvidersand pass them to theNewMultiProvidermethod along with a strategy and any options.Verify the results are as expected based on the strategy.