fix: selector not being sent in sync call #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
chrfwow
approved these changes
Feb 13, 2025
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
fix/fixing_missing_selector
branch
2 times, most recently
from
05acb98 to
325a736
Compare
aepfli
commented
Feb 13, 2025
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFileTest.java
Show resolved
Hide resolved
aepfli
force-pushed
the
fix/fixing_missing_selector
branch
from
325a736 to
35ebcc4
Compare
aepfli
force-pushed
the
fix/fixing_missing_selector
branch
from
35ebcc4 to
901eb28
Compare
toddbaert
changed the title
toddbaert
changed the title
It was lost in a recent (and very nice-to-have) refactor. It's easy to see why it was lost, but now the e2e will protect us from similar regressions. |
toddbaert
approved these changes
Feb 13, 2025
Nikzz3
pushed a commit
to Nikzz3/java-sdk-contrib
that referenced
this pull request
Feb 17, 2025
Signed-off-by: Simon Schrottner <[email protected]> Signed-off-by: Nick Zimmermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some how the selector implementation got lost