feat: Add JUnit5 extension for OpenFeature #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aepfli
force-pushed
the
feat/junit-extension
branch
from
d1ba6a1 to
7e46d11
Compare
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
aepfli
force-pushed
the
feat/junit-extension
branch
2 times, most recently
from
2e44bdf to
5c3cead
Compare
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/junit-extension
branch
from
5c3cead to
b177459
Compare
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/junit-extension
branch
from
ad5d31e to
61a7bc0
Compare
aepfli
commented
Jul 22, 2024
Signed-off-by: Simon Schrottner <[email protected]>
...openfeature/src/test/java/dev/openfeature/contrib/tools/junitopenfeature/StringFlagTest.java
Show resolved
Hide resolved
thisthat
reviewed
Jul 22, 2024
...it-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/OpenFeature.java
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <[email protected]>
toddbaert
reviewed
Jul 23, 2024
|
This is very cool. |
...t-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/TestProvider.java
Outdated
Show resolved
Hide resolved
...t-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/TestProvider.java
Outdated
Show resolved
Hide resolved
...t-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/TestProvider.java
Outdated
Show resolved
Hide resolved
...t-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/TestProvider.java
Show resolved
Hide resolved
Kavindu-Dodan
approved these changes
Jul 23, 2024
…fixes Signed-off-by: Simon Schrottner <[email protected]>
beeme1mr
reviewed
Jul 25, 2024
toddbaert
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Code-wise, this looks good to me (though consider the feedback from others).
The blockers for me are that you need to update the release-manifest and config, and add yourself as an owner to this component in the component owners.
aepfli
force-pushed
the
feat/junit-extension
branch
from
8b586a5 to
a58b07d
Compare
…fixes Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/junit-extension
branch
from
a58b07d to
74a9ff8
Compare
Signed-off-by: Simon Schrottner <[email protected]>
i added those entries in the files, pls recheck |
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
beeme1mr
approved these changes
Jul 25, 2024
toddbaert
reviewed
Jul 26, 2024
toddbaert
approved these changes
Jul 26, 2024
|
Amazing work, really nice to have. |
|
Hey @aepfli, please rebase when have a moment. I've enabled auto-merging, but it won't happen until this branch is up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adding a junit5 extension allows the user to reduce boilerplate code in his unit tests.
This extension will prefill the InMemoryProvider with a flag configuration.
todo