feat: Init web-sdk go-feature-flag

[thomaspoignant]

This PR

• 1st version of the web-sdk for GO Feature Flag

Related Issues

Fixes thomaspoignant/go-feature-flag#662

[toddbaert]

@thomaspoignant super cool! I will give this a full review later today!

[thomaspoignant]

@toddbaert I've addressed all your comments, including using fetch rather than axios.
If you don't mind doing another review it would be awesome.

I think we should wait the release of a stable SDK to be available before merging this PR.

[toddbaert]

Sorry @thomaspoignant I will re-review this first thing tomorrow

[thomaspoignant]

Sorry @thomaspoignant I will re-review this first thing tomorrow

No rush, no worries

[toddbaert]

@thomaspoignant looks great to me! Only minor nits that are opinions. Please be careful resolving conflicts in the .release-please-manifest 😅

I plan on releasing our first non-experimental web-sdk on Monday, with this change: open-feature/js-sdk#507 (comment). I'm waiting until then to give people a few days to update the providers impacted by the change.

You can wait until then if you'd like to set a proper peer for this.

[beeme1mr]

Awesome, nice job @thomaspoignant! We should extend the playground to support client-side GOFF once this has been published.

[beeme1mr]

@toddbaert, it looks like the CI is failing because of flagd. I'm assuming the NX affecting command detected so many components because the root package json was modified, right? Either way, we should unblock Thomas.

[thomaspoignant]

Awesome, nice job @thomaspoignant! We should extend the playground to support client-side GOFF once this has been published.

Sure I will look at it as soon as we merge it.

[toddbaert]

@toddbaert, it looks like the CI is failing because of flagd. I'm assuming the NX affecting command detected so many components because the root package json was modified, right? Either way, we should unblock Thomas.

@beeme1mr ya that's why all the packages were rebuilt, but more specifically there's a race condition that happens sometimes when git attempts to pull sub-modules. It's rare, but annoying:

error: could not lock config file /home/runner/work/js-sdk-contrib/js-sdk-contrib/.git/modules/libs/providers/flagd-web/schemas/config: File exists
fatal: could not set 'core.worktree' to '../../../../../../libs/providers/flagd-web/schemas'
Warning: run-commands command "git submodule update --init --recursive" exited with non-zero status code

I re-ran the suite, but now it's failing on some GoFF specific tests. I will see what can be done about the submodule race.

[thomaspoignant]

I re-ran the suite, but now it's failing on some GoFF specific tests. I will see what can be done about the submodule race.

I can have a look at those ones.