fix: only initialize NOT_READY providers #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2023
toddbaert
changed the title
toddbaert
force-pushed
the
fix/only-init-not-ready
branch
from
c258b64 to
0eb553f
Compare
thomaspoignant
approved these changes
Jul 26, 2023
toddbaert
commented
Jul 26, 2023
toddbaert
commented
Jul 26, 2023
|
Hey, just wondering, do we already have a provider that implement the correct behavior? |
lukas-reining
approved these changes
Jul 26, 2023
beeme1mr
approved these changes
Jul 26, 2023
toddbaert
force-pushed
the
fix/only-init-not-ready
branch
from
0eb553f to
c6cbe04
Compare
@thomaspoignant the launchdarkly provider does: https://github.com/open-feature/js-sdk-contrib/blob/main/libs/providers/launchdarkly-client/src/lib/launchdarkly-client-provider.ts#L96-L99. So does the in-progress implementation of flagd-js-server: open-feature/js-sdk-contrib#484 |
toddbaert
commented
Jul 27, 2023
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/only-init-not-ready
branch
from
c648f41 to
7b6ab22
Compare
|
This is fixed in all the providers I know needed to be updated. I will merge this in the next few days and release the artifact as our first non-experimental version if that's fine with you all. |
Signed-off-by: Todd Baert <[email protected]>
This was referenced Jul 31, 2023
toddbaert
pushed a commit
that referenced
this pull request
Jul 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.10](shared-v0.0.9...shared-v0.0.10) (2023-07-31) ### Bug Fixes * only initialize NOT_READY providers ([#507](#507)) ([5e320ae](5e320ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
toddbaert
added a commit
that referenced
this pull request
Jul 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.11](web-sdk-v0.3.10-experimental...web-sdk-v0.3.11) (2023-07-31) ### Bug Fixes * only initialize NOT_READY providers ([#507](#507)) ([5e320ae](5e320ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Todd Baert <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Baert <[email protected]>
beeme1mr
pushed a commit
that referenced
this pull request
Aug 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.4.2](js-sdk-v1.4.1...js-sdk-v1.4.2) (2023-08-07) ### Bug Fixes * only initialize NOT_READY providers ([#507](#507)) ([5e320ae](5e320ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here. We should only run initialize if
ProviderStatusisNOT_READYto prevent duplicate calls toinitialize, as we Java and Go.Most of this is test and formatting changes (I had to update the tests not to use the same object literal). The import change is the single line here.
Note: it's likely this will break some providers that didn't implement
status. I think the flagd web provider, GoFF provider and the config-cat could be impacted. I created issues for these:Fixes: #505
I've also removed all the
setTimeoutsin our test suite. Everything is working "properly" now with plain events, since all flagd providers are fully updated.