Update .instrument() call response_hook argument name in the documentation for Botocore and Pymongo
#1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
srikanthccv
approved these changes
Mar 21, 2022
srikanthccv
added
the
Skip Changelog
Have signed the CLA @srikanthccv |
|
/easycla |
|
@rahulgupta92 Either you didn't sign the cla completely or EasyCLA is not working. Please check again. |
@srikanthccv I have signed multiple times now as an Individual Contributor but it redirects me to this page after signing it successfully without any change in the PR status. Anything which i am missing? Does this need to be done via Corporate Contributor route only? |
lzchen
approved these changes
Mar 21, 2022
…e header comments
rahulgupta92
force-pushed
the
update-response-hook-documentation
branch
from
aeeb8ad to
4d0f3b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current documentation for Botocore and Pymongo instrumentation has incorrectly specified the argument
response_hookasresponse_hooksfor the.instrument()call. This PR fixes the argument name to useresponse_hookinstead.Correct Format:
BotocoreInstrumentor().instrument(request_hook=request_hook, response_hook=response_hook)PymongoInstrumentor().instrument(request_hook=request_hook, response_hook=response_hook, failed_hook=failed_hook)Type of change
How Has This Been Tested?
All tests of the project have been run.
Does This PR Require a Core Repo Change?
Checklist: