Skip to content

Update .instrument() call response_hook argument name in the documentation for Botocore and Pymongo #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Update .instrument() call response_hook argument name in the documentation for Botocore and Pymongo #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d0f3b5
Update .instrument() call signature response_hook argument name in th…
rahulgupta92 Mar 21, 2022
ff06604
Merge branch 'main' into update-response-hook-documentation
srikanthccv Mar 21, 2022
41d9875
Merge branch 'main' into update-response-hook-documentation
srikanthccv Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...telemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def response_hook(span, service_name, operation_name, result):
# response hook logic

# Instrument Botocore with hooks
BotocoreInstrumentor().instrument(request_hook=request_hook, response_hooks=response_hook)
BotocoreInstrumentor().instrument(request_hook=request_hook, response_hook=response_hook)

# This will create a span with Botocore-specific attributes, including custom attributes added from the hooks
session = botocore.session.get_session()
Expand Down
2 changes: 1 addition & 1 deletion ...entelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def failed_hook(span, event):
# failed hook logic

# Instrument pymongo with hooks
PymongoInstrumentor().instrument(request_hook=request_hook, response_hooks=response_hook, failed_hook=failed_hook)
PymongoInstrumentor().instrument(request_hook=request_hook, response_hook=response_hook, failed_hook=failed_hook)

# This will create a span with pymongo specific attributes, including custom attributes added from the hooks
client = MongoClient()
Expand Down