Use is_recording flag in requests instrumentation #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Sep 9, 2020
instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py
Outdated
Show resolved
Hide resolved
codeboten
approved these changes
Sep 10, 2020
aabmass
reviewed
Sep 11, 2020
| result = self.perform_request(self.URL) | ||
| self.assertEqual(result.text, "Hello!") | ||
|
|
||
| span = self.assert_span(None, 0) |
There was a problem hiding this comment.
Looks to me like this would pass regardless of the code change since the result isn't actually different, which is fine if this behavior wasn't checked before.
But also patching (I think) opentelemetry.trace.INVALID_SPAN and then checking that is_recording() was called, set_attribute() was never called, etc. would be good to verify this PR's behavior
aabmass
approved these changes
Sep 14, 2020
Comment on lines
164
to
166
| with self.assertRaises(AttributeError): | ||
| # pylint: disable=pointless-statement | ||
| mock_span.attributes |
There was a problem hiding this comment.
I think the AttributeError is only raised because of autospec=True?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1057
The test util was also missing a dependency to the sdk package, which it uses