Use is_recording flag in requests instrumentation

instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py

@@ -121,39 +121,45 @@ def _instrumented_requests_call(
         with get_tracer(
             __name__, __version__, tracer_provider
         ).start_as_current_span(span_name, kind=SpanKind.CLIENT) as span:
-            span.set_attribute("component", "http")
-            span.set_attribute("http.method", method.upper())
-            span.set_attribute("http.url", url)
+            if span.is_recording():
+                span.set_attribute("component", "http")
+                span.set_attribute("http.method", method.upper())
+                span.set_attribute("http.url", url)
 
-            headers = get_or_create_headers()
-            propagators.inject(type(headers).__setitem__, headers)
+                headers = get_or_create_headers()
+                propagators.inject(type(headers).__setitem__, headers)
 
-            token = context.attach(
-                context.set_value(_SUPPRESS_REQUESTS_INSTRUMENTATION_KEY, True)
-            )
-            try:
-                result = call_wrapped()  # *** PROCEED
-            except Exception as exc:  # pylint: disable=W0703
-                exception = exc
-                result = getattr(exc, "response", None)
-            finally:
-                context.detach(token)
-
-            if exception is not None:
-                span.set_status(
-                    Status(_exception_to_canonical_code(exception))
-                )
-                span.record_exception(exception)
-
-            if result is not None:
-                span.set_attribute("http.status_code", result.status_code)
-                span.set_attribute("http.status_text", result.reason)
-                span.set_status(
-                    Status(http_status_to_canonical_code(result.status_code))
+                token = context.attach(
+                    context.set_value(_SUPPRESS_REQUESTS_INSTRUMENTATION_KEY, True)
                 )
-
-            if span_callback is not None:
-                span_callback(span, result)
+                try:
+                    result = call_wrapped()  # *** PROCEED
+                except Exception as exc:  # pylint: disable=W0703
+                    exception = exc
+                    result = getattr(exc, "response", None)
+                finally:
+                    context.detach(token)
+
+                if exception is not None:
+                    span.set_status(
+                        Status(_exception_to_canonical_code(exception))
+                    )
+                    span.record_exception(exception)
+
+                if result is not None:
+                    span.set_attribute("http.status_code", result.status_code)
+                    span.set_attribute("http.status_text", result.reason)
+                    span.set_status(
+                        Status(http_status_to_canonical_code(result.status_code))
+                    )
+
+                if span_callback is not None:
+                    span_callback(span, result)
+            else:
+                try:
+                    result = call_wrapped()  # *** PROCEED
+                except Exception as exc:  # pylint: disable=W0703
+                    exception = exc
 
         if exception is not None:
             raise exception.with_traceback(exception.__traceback__)

instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py

@@ -147,6 +147,19 @@ def test_suppress_instrumentation(self):
 
         self.assert_span(num_spans=0)
 
+    def test_not_recording(self):
+        RequestsInstrumentor().uninstrument()
+        RequestsInstrumentor().instrument(
+            tracer_provider=self.original_tracer_provider
+        )
+
+        result = self.perform_request(self.URL)
+        self.assertEqual(result.text, "Hello!")
+
+        span = self.assert_span(None, 0)
+        with self.assertRaises(AttributeError):
+            attr = span.attributes
+
     def test_distributed_context(self):
         previous_propagator = propagators.get_global_httptextformat()
         try:

tests/util/setup.cfg

@@ -39,6 +39,7 @@ package_dir=
 packages=find_namespace:
 install_requires =
     opentelemetry-api
+    opentelemetry-sdk
 
 [options.extras_require]
 test = flask~=1.0