Skip to content

Verify previous point is returned for cumulative instruments #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 30, 2022
Merged

Verify previous point is returned for cumulative instruments #2773

merged 7 commits into from
Jun 30, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jun 21, 2022

Fixes #2755

@ocelotl ocelotl requested a review from a team June 21, 2022 08:14
@ocelotl ocelotl self-assigned this Jun 21, 2022
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 21, 2022
@ocelotl ocelotl requested a review from lzchen June 24, 2022 15:46
@lzchen
Copy link
Contributor

lzchen commented Jun 24, 2022

@srikanthccv and @aabmass could probably provide a better review.

@ocelotl ocelotl requested a review from srikanthccv June 27, 2022 11:50
@srikanthccv
Copy link
Member

I may have forgotten what's happening here https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py#L139-L144. I would like another approval on this before merging.

@srikanthccv srikanthccv requested a review from aabmass June 28, 2022 18:52
aabmass
aabmass reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR just to verify the behavior of Prometheus? I was thinking we should test this for the SDK's behavior, e.g. with InMemoryMetricReader and cumulative config.

Basically what Srikanth said, I'd like to know if the internals of SDK are working not just prom

@ocelotl
Copy link
Contributor Author

ocelotl commented Jun 30, 2022

Is this PR just to verify the behavior of Prometheus? I was thinking we should test this for the SDK's behavior, e.g. with InMemoryMetricReader and cumulative config.

Basically what Srikanth said, I'd like to know if the internals of SDK are working not just prom

Fair point, I added another test that uses InMemoryMetricReader.

@ocelotl ocelotl requested a review from aabmass June 30, 2022 17:07
@ocelotl
Copy link
Contributor Author

ocelotl commented Jun 30, 2022

@aabmass removed the parameters, PTAL 👍

@ocelotl ocelotl mentioned this pull request Jun 30, 2022
Closed
@lzchen lzchen mentioned this pull request Jun 30, 2022
Merged
@ocelotl ocelotl merged commit f7a3e62 into open-telemetry:main Jun 30, 2022
@ocelotl ocelotl deleted the issue_2755 branch June 30, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify prev point is returned for cumulative readers instead of None
4 participants
@ocelotl @lzchen @srikanthccv @aabmass