Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding logging format lint check #4525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding logging format lint check #4525

wants to merge 1 commit into from
+4 −3

Conversation

thogar-computer
Copy link

@thogar-computer thogar-computer commented Apr 2, 2025 •
edited
Loading

Description

Fixes #4227

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • test-opentelemetry-exporter-otlp-proto-common

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@thogar-computer thogar-computer requested a review from a team as a code owner April 2, 2025 16:27
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 2, 2025 •
edited
Loading

CLA Signed

  • ✅login: thogar-computer / (37426c2)

The committers listed above are authorized under a signed CLA.

pmcollins
pmcollins approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks. Please take a look at the pre-commit failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcollins pmcollins pmcollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more rules to ruff linter
2 participants
@thogar-computer @pmcollins