Skip to content

adding logging format lint check #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
+7 −5
Merged

adding logging format lint check #4525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37426c2
adding logging format lint check
thogar-computer Apr 2, 2025
43ab3af
changes from ruff format command
thogar-computer Apr 9, 2025
e759d1b
Merge branch 'main' into feature/linting-ruff-G
xrmx Apr 9, 2025
52a0d35
reapplying format changes changes
thogar-computer Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...common/src/opentelemetry/exporter/otlp/proto/common/_internal/metrics_encoder/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ def _get_temporality(
_logger.warning(
"Unrecognized OTEL_EXPORTER_METRICS_TEMPORALITY_PREFERENCE"
" value found: "
f"{otel_exporter_otlp_metrics_temporality_preference}, "
"using CUMULATIVE"
"%s, "
"using CUMULATIVE",
otel_exporter_otlp_metrics_temporality_preference,
)
instrument_class_temporality = {
Counter: AggregationTemporality.CUMULATIVE,
Expand Down
3 changes: 2 additions & 1 deletion ...telemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def _read_file(file_path: str) -> Optional[bytes]:
return file.read()
except FileNotFoundError as e:
logger.exception(
f"Failed to read file: {e.filename}. Please check if the file exists and is accessible."
"Failed to read file: %s. Please check if the file exists and is accessible.",
e.filename,
)
return None

Expand Down
3 changes: 1 addition & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/error_handler/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ def __exit__(self, exc_type, exc_value, traceback):
# pylint: disable=broad-exception-caught
except Exception as error_handling_error:
logger.exception(
"%s error while handling error"
" %s by error handler %s",
"%s error while handling error %s by error handler %s",
error_handling_error.__class__.__name__,
exc_value.__class__.__name__,
error_handler_class.__name__,
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ select = [
"PLC", # pylint convention
"PLE", # pylint error
"Q", # flake8-quotes
"G", # https://docs.astral.sh/ruff/rules/#flake8-logging-format-g
]

ignore = [
Expand Down